Fix config docs update workflow#10
Merged
Merged
Conversation
The workflow fails because Pillow system dependencies are not available, which are required by Material for MkDocs, but not the generation script. Use uv dependency groups to separate the two concerns. Signed-off-by: nscuro <nscuro@protonmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the “Update Config Documentation” workflow by separating the config-doc generation script’s dependencies from the MkDocs/Material (imaging/Pillow) dependencies that require additional system packages.
Changes:
- Move
jinja2out of the project’s main dependencies into a dedicatedgeneratedependency group. - Update
generate-config-docsto run using only thegenerategroup viauv run --only-group generate. - Update
uv.lockto include the new dependency group metadata.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pyproject.toml |
Introduces a generate dependency group and removes jinja2 from main dependencies. |
Makefile |
Runs config-doc generation with uv restricted to the generate group. |
uv.lock |
Adds generate group entries, but currently appears inconsistent with the updated pyproject.toml metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow fails because Pillow system dependencies are not available, which are required by Material for MkDocs, but not the generation script.
Use uv dependency groups to separate the two concerns.